- Drop the float64-precision sub-test from TestLookupFloat64; it tests a
  structural property unrelated to conditional fallback that this PR
  doesn't touch.
- Drop the conditional.eq cases; the gRPC test cases already exercise Eq
  accept/reject on a realistic concept.
- Drop the conditional.present/conditional.absent cases; Present is
  unused in mappings.json today and the AND test covers Present:true
  implicitly.
- Rename testBoolPtr to boolPtr (the _test.go suffix already conveys it
  is test-only).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…nal check inline

Drop the lookupWithConditions/readTag/readFloat64Tag/readInt64Tag
extraction. The conditional fallback feature only needs a single
`if !conditionsMatch(...) { continue }` line at the top of each loop;
extracting per-type readers and a generic helper was orthogonal
churn that obscured the diff.

Net diff vs main: +37 lines, 0 deletions to existing code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The pre-refactor getOTelGRPCStatusCode used GetOTelAttrFromEitherMap with
keys ("rpc.system.name", "rpc.system"), which returns the first non-empty
key — so when an SDK sets rpc.system.name=jsonrpc and (incorrectly) also
rpc.system=grpc, the new key wins and rpc.response.status_code is rejected.

Without this fix the two independent registry rows would each evaluate
against their own attribute, and the legacy rpc.system=grpc row would
match — accepting a status code that pre-PR rejected.

Gate the legacy rows on rpc.system.name being absent so the new semconv
key remains authoritative when both are present.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- TestConditionalLookup now uses NewEmbeddedRegistry() against the real
  mappings.json instead of a hand-rolled fake. Removes ~50 lines of
  Provider/Type struct-literal boilerplate and the synthetic
  conditional.and concept (the rpc.system+rpc.system.name two-condition
  AND in production gives implicit AND coverage). boolPtr helper is no
  longer needed.
- Collapse the duplicated `c.Present != nil` check at the tail of
  conditionMatches into a single return.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…C keys

rpc.response.status_code and rpc.system.name were both first added to
OTel semantic-conventions in v1.39.0 (Jan 2026), not v1.24.0 (Dec 2023).

Verified against the upstream repo:
  - rpc.response.status_code: commit cd5b45c6 (2025-12-04), .chloggen/rpc-status-code.yaml
    "Deprecate per-rpc status code attributes in favor of rpc.response.status_code"
  - rpc.system.name: commit 18db3e44 (2025-12-09), .chloggen/rpc-system-name.yaml
    "Align RPC conventions with naming guidelines. Renames rpc.system to rpc.system.name."

Both commits land in v1.39.0 (published 2026-01-12). model/registry/rpc.yaml
at v1.24.0 has neither attribute.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull the "no declared predicate" default to the top with a comment, then
check each declared predicate independently. Removes the trailing
`return c.Present != nil || found` boolean fold whose meaning was easy
to mis-read.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The single-letter local was idiomatic but unclear in context. Both
locals now self-document: `value := accessor.GetString(c.Attribute)`
and `found := value != ""`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…onMatches

A Condition with neither Present nor Eq set is unused in mappings.json
today, and the special-case "fall back to presence check" branch was
the most confusing line in the function (per reviewer feedback).

Treat an empty Condition as a no-op (always true), consistent with how
an empty `when: []` array also returns true (zero-iteration loop is
vacuously true). Authors who want a presence check write
{"attribute": "X", "present": true} explicitly.

Function shrinks from 14 to 11 lines; doc comment now states the
semantics explicitly without referring to a degenerate path.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…predicate

The vast majority of fallback rows in mappings.json have no `when`
clause; calling conditionsMatch on those rows just iterates an empty
slice and returns true. Adding `len(tag.When) > 0 &&` at each call site
makes the conditional structure visible at the lookup site (most rows
unconditional, some conditional) and avoids the dead function call.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>